From 9647f1160f747e57f8ee70f654a8a7a647a18f04 Mon Sep 17 00:00:00 2001 From: 0xboobface <0xboobface@gmail.com> Date: Fri, 5 Apr 2019 14:50:45 +0200 Subject: [PATCH] Fix: Errors thrown by external browser This hopefully fixes the errors, which popped up in the external browser, because it tried to write to a closed socket. --- .../src/main/java/ctbrec/ui/ExternalBrowser.java | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/client/src/main/java/ctbrec/ui/ExternalBrowser.java b/client/src/main/java/ctbrec/ui/ExternalBrowser.java index e15ec675..c25bffe4 100644 --- a/client/src/main/java/ctbrec/ui/ExternalBrowser.java +++ b/client/src/main/java/ctbrec/ui/ExternalBrowser.java @@ -68,6 +68,10 @@ public class ExternalBrowser implements AutoCloseable { p.waitFor(); int exitValue = p.exitValue(); p = null; + reader = null; + in = null; + out = null; + this.messageListener = null; LOG.debug("Browser Process terminated with {}", exitValue); } finally { lock.unlock(); @@ -117,17 +121,6 @@ public class ExternalBrowser implements AutoCloseable { } stopped = true; executeJavaScript("quit"); - if(socket != null) { - socket.close(); - socket = null; - } - messageListener = null; - reader = null; - in = null; - out = null; - if(p != null) { - p.destroy(); - } } private void readBrowserOutput() {