From 47469c8aea17f308a3c51653c00f721d3b5f9197 Mon Sep 17 00:00:00 2001 From: 0xb00bface <0xboobface@gmail.com> Date: Sat, 8 May 2021 19:11:11 +0200 Subject: [PATCH] Avoid swallowing of exceptions by catching them all --- .../src/main/java/ctbrec/recorder/NextGenLocalRecorder.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/src/main/java/ctbrec/recorder/NextGenLocalRecorder.java b/common/src/main/java/ctbrec/recorder/NextGenLocalRecorder.java index 2064744d..fa29d037 100644 --- a/common/src/main/java/ctbrec/recorder/NextGenLocalRecorder.java +++ b/common/src/main/java/ctbrec/recorder/NextGenLocalRecorder.java @@ -267,7 +267,7 @@ public class NextGenLocalRecorder implements Recorder { } } - private CompletableFuture startRecordingProcess(Model model) throws IOException { + private CompletableFuture startRecordingProcess(Model model) { return CompletableFuture.runAsync(() -> { recorderLock.lock(); try { @@ -286,7 +286,7 @@ public class NextGenLocalRecorder implements Recorder { executeRecordUntilSubsequentAction(model); } catch (PreconditionNotMetException e) { LOG.info("Precondition not met to record {}: {}", model, e.getLocalizedMessage()); - } catch (IOException e) { + } catch (Exception e) { LOG.error("Couldn't start recording process for {}", model, e); } finally { recorderLock.unlock();