From c609014952f8153fc58bbc4b66c1caa508e75db7 Mon Sep 17 00:00:00 2001 From: 0xb00bface <0xboobface@gmail.com> Date: Sun, 22 Aug 2021 12:06:30 +0200 Subject: [PATCH] Use a constant for the silhouette image ... so that it only gets loaded once --- .../ctbrec/ui/tabs/recorded/AbstractRecordedModelsTab.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/client/src/main/java/ctbrec/ui/tabs/recorded/AbstractRecordedModelsTab.java b/client/src/main/java/ctbrec/ui/tabs/recorded/AbstractRecordedModelsTab.java index 7b0fa3d6..4698c853 100644 --- a/client/src/main/java/ctbrec/ui/tabs/recorded/AbstractRecordedModelsTab.java +++ b/client/src/main/java/ctbrec/ui/tabs/recorded/AbstractRecordedModelsTab.java @@ -81,6 +81,7 @@ import javafx.util.Callback; public abstract class AbstractRecordedModelsTab extends Tab implements TabSelectionListener { private static final Logger LOG = LoggerFactory.getLogger(AbstractRecordedModelsTab.class); + private static Image SILHOUETTE = new Image(AbstractRecordedModelsTab.class.getResourceAsStream("/silhouette_256.png")); protected ReentrantLock lock = new ReentrantLock(); protected ObservableList observableModels = FXCollections.observableArrayList(); @@ -110,6 +111,7 @@ public abstract class AbstractRecordedModelsTab extends Tab implements TabSelect AbstractRecordedModelsTab(String text) { super(text); + registerPortraitListener(); } @@ -567,7 +569,7 @@ public abstract class AbstractRecordedModelsTab extends Tab implements TabSelect LOG.error("Couldn't load portrait file {}", portraitFile, e); } } - return new Image(AbstractRecordedModelsTab.class.getResourceAsStream("/silhouette_256.png")); + return SILHOUETTE; } protected void showColumnSelection(ActionEvent evt) {