From 844295101eadbee99c7d6f98234d82856f545d5e Mon Sep 17 00:00:00 2001 From: 0xb00bface <0xboobface@gmail.com> Date: Sat, 23 Jan 2021 18:48:23 +0100 Subject: [PATCH] Fix bug: "split bigger than" not being changeable --- .../java/ctbrec/ui/settings/CtbrecPreferencesStorage.java | 1 - client/src/main/java/ctbrec/ui/settings/SettingsTab.java | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/client/src/main/java/ctbrec/ui/settings/CtbrecPreferencesStorage.java b/client/src/main/java/ctbrec/ui/settings/CtbrecPreferencesStorage.java index 3423bfda..e330b56b 100644 --- a/client/src/main/java/ctbrec/ui/settings/CtbrecPreferencesStorage.java +++ b/client/src/main/java/ctbrec/ui/settings/CtbrecPreferencesStorage.java @@ -290,7 +290,6 @@ public class CtbrecPreferencesStorage implements PreferencesStorage { ComboBox comboBox = new ComboBox(listProp); Field field = Settings.class.getField(setting.getKey()); Object value = field.get(settings); - LOG.debug("{} {} {}", setting.getName(), value, setting.getProperty().getValue()); if (StringUtil.isNotBlank(value.toString())) { if (setting.getConverter() != null) { comboBox.getSelectionModel().select(setting.getConverter().convertTo(value)); diff --git a/client/src/main/java/ctbrec/ui/settings/SettingsTab.java b/client/src/main/java/ctbrec/ui/settings/SettingsTab.java index df6a7cd9..c7b9539c 100644 --- a/client/src/main/java/ctbrec/ui/settings/SettingsTab.java +++ b/client/src/main/java/ctbrec/ui/settings/SettingsTab.java @@ -343,9 +343,7 @@ public class SettingsTab extends Tab implements TabSelectionListener { private void splitValuesChanged(ObservableValue value, Object oldV, Object newV) { boolean splitAfterSet = settings.splitRecordingsAfterSecs > 0; - LOG.debug("after {}", settings.splitRecordingsAfterSecs); boolean splitBiggerThanSet = settings.splitRecordingsBiggerThanBytes > 0; - LOG.debug("bigger {}", settings.splitRecordingsBiggerThanBytes); if (splitAfterSet && splitBiggerThanSet) { settings.splitStrategy = TIME_OR_SIZE; } else if (splitAfterSet) { @@ -355,7 +353,6 @@ public class SettingsTab extends Tab implements TabSelectionListener { } else { settings.splitStrategy = DONT; } - LOG.debug("strats {}", settings.splitStrategy); saveConfig(); } @@ -587,7 +584,7 @@ public class SettingsTab extends Tab implements TabSelectionListener { if (getClass() != obj.getClass()) return false; SplitBiggerThanOption other = (SplitBiggerThanOption) obj; - return value != other.value; + return value == other.value; } public static ValueConverter converter() {