j62
/
ctbrec
2
2
Fork 2
Code Issues 5 Pull Requests Packages Projects Releases 3 Wiki Activity

Avoid swallowing of exceptions by catching them all

This commit is contained in:
0xb00bface 2021-05-08 19:11:11 +02:00
parent c96138ed6e
commit 47469c8aea
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
common/src/main/java/ctbrec/recorder/NextGenLocalRecorder.java
View File

@ -267,7 +267,7 @@ public class NextGenLocalRecorder implements Recorder {
} }
} }
private CompletableFuture<Void> startRecordingProcess(Model model) throws IOException { private CompletableFuture<Void> startRecordingProcess(Model model) {
return CompletableFuture.runAsync(() -> { return CompletableFuture.runAsync(() -> {
recorderLock.lock(); recorderLock.lock();
try { try {
@ -286,7 +286,7 @@ public class NextGenLocalRecorder implements Recorder {
executeRecordUntilSubsequentAction(model); executeRecordUntilSubsequentAction(model);
} catch (PreconditionNotMetException e) { } catch (PreconditionNotMetException e) {
LOG.info("Precondition not met to record {}: {}", model, e.getLocalizedMessage()); LOG.info("Precondition not met to record {}: {}", model, e.getLocalizedMessage());
} catch (IOException e) { } catch (Exception e) {
LOG.error("Couldn't start recording process for {}", model, e); LOG.error("Couldn't start recording process for {}", model, e);
} finally { } finally {
recorderLock.unlock(); recorderLock.unlock();